aws-actions/configure-aws-credentials
1
0
Fork 0
mirror of https://github.com/aws-actions/configure-aws-credentials.git synced 2026-09-04 06:15:07 +09:00
Code Issues Packages Projects Releases Wiki Activity

fix: skips session tagging (#209)

Browse Source
This commit is contained in:
Parag Sanjay Bhingre
2021-05-11 15:00:49 -04:00
committed by GitHub
parent 745b3becf5
commit 4900858c22
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
index.js
+9 -2
View File
@@ -57,6 +57,12 @@ async function assumeRole(params) {
const roleSessionTags = roleSkipSessionTagging ? undefined : tagArray; const roleSessionTags = roleSkipSessionTagging ? undefined : tagArray;
if(roleSessionTags == undefined){
core.debug("Role session tagging has been skipped.")
} else {
core.debug(roleSessionTags.length + " role session tags are being used.")
}
const assumeRoleRequest = { const assumeRoleRequest = {
RoleArn: roleArn, RoleArn: roleArn,
RoleSessionName: roleSessionName, RoleSessionName: roleSessionName,
@@ -203,8 +209,9 @@ async function run() {
const roleExternalId = core.getInput('role-external-id', { required: false }); const roleExternalId = core.getInput('role-external-id', { required: false });
const roleDurationSeconds = core.getInput('role-duration-seconds', {required: false}) || MAX_ACTION_RUNTIME; const roleDurationSeconds = core.getInput('role-duration-seconds', {required: false}) || MAX_ACTION_RUNTIME;
const roleSessionName = core.getInput('role-session-name', { required: false }) || ROLE_SESSION_NAME; const roleSessionName = core.getInput('role-session-name', { required: false }) || ROLE_SESSION_NAME;
const roleSkipSessionTagging = core.getInput('role-skip-session-tagging', { required: false }); const roleSkipSessionTaggingInput = core.getInput('role-skip-session-tagging', { required: false })|| 'false';
const roleSkipSessionTagging = roleSkipSessionTaggingInput.toLowerCase() === 'true';
if (!region.match(REGION_REGEX)) { if (!region.match(REGION_REGEX)) {
throw new Error(`Region is not valid: ${region}`); throw new Error(`Region is not valid: ${region}`);
} }
index.test.js
+2 -2
View File
@@ -559,7 +559,7 @@ describe('Configure AWS Credentials', () => {
test('skip tagging provided as true', async () => { test('skip tagging provided as true', async () => {
core.getInput = jest core.getInput = jest
.fn() .fn()
.mockImplementation(mockGetInput({...ASSUME_ROLE_INPUTS, 'role-skip-session-tagging': true})); .mockImplementation(mockGetInput({...ASSUME_ROLE_INPUTS, 'role-skip-session-tagging': 'true'}));
await run(); await run();
expect(mockStsAssumeRole).toHaveBeenCalledWith({ expect(mockStsAssumeRole).toHaveBeenCalledWith({
@@ -573,7 +573,7 @@ describe('Configure AWS Credentials', () => {
test('skip tagging provided as false', async () => { test('skip tagging provided as false', async () => {
core.getInput = jest core.getInput = jest
.fn() .fn()
.mockImplementation(mockGetInput({...ASSUME_ROLE_INPUTS, 'role-skip-session-tagging': false})); .mockImplementation(mockGetInput({...ASSUME_ROLE_INPUTS, 'role-skip-session-tagging': 'false'}));
await run(); await run();
expect(mockStsAssumeRole).toHaveBeenCalledWith({ expect(mockStsAssumeRole).toHaveBeenCalledWith({