fix: reject newlines in names and values when writing profile files

If the profile file writing was enabled, we emitted newlines into the
file verbatim, permitting injecting arbitrary profiles into the file.
Writing now fails instead.
This commit is contained in:
Tom Keller
2026-08-31 12:00:11 -07:00
parent 1f2d3ed486
commit 82408b69eb
2 changed files with 41 additions and 0 deletions
+34
View File
@@ -114,6 +114,22 @@ describe('Profile Manager', {}, () => {
const result = stringifyIni({ dev: {} });
expect(result).toBe('[dev]\n');
});
it('rejects values containing newlines', {}, () => {
expect(() =>
stringifyIni({ dev: { aws_session_token: 'token\n[injected]\ncredential_process = evil' } }),
).toThrow('must not contain newline characters');
});
it('rejects keys containing newlines', {}, () => {
expect(() => stringifyIni({ dev: { 'key\ninjected': 'val' } })).toThrow('must not contain newline characters');
});
it('rejects section names containing newlines', {}, () => {
expect(() => stringifyIni({ 'dev\r\n[injected]': { key: 'val' } })).toThrow(
'must not contain newline characters',
);
});
});
describe('validateProfileName', {}, () => {
@@ -423,6 +439,24 @@ describe('Profile Manager', {}, () => {
expect(configParsed['profile dev'].region).toBe('us-east-1');
});
it('refuses to write credentials containing newlines instead of injecting profiles', {}, () => {
expect(() =>
writeProfileFiles(
'dev',
{
AccessKeyId: 'AKIAIOSFODNN7EXAMPLE',
SecretAccessKey: 'wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY',
SessionToken: 'token\n[injected]\ncredential_process = evil-command',
},
'us-east-1',
false,
),
).toThrow('must not contain newline characters');
const credsPath = getProfileFilePaths().credentials;
expect(fs.existsSync(credsPath)).toBe(false);
});
it('uses correct section naming for default profile', {}, () => {
writeProfileFiles(
'default',