fix: maxRetry hit infinite loop with negative input

dist/cleanup/index.js

@@ -17699,7 +17699,7 @@ async function retryAndBackoff(fn, isRetryable, maxRetries = 12, retries = 0, ba
         // It's retryable, so sleep and retry.
         await sleep(Math.random() * (Math.pow(2, retries) * base));
         retries += 1;
-        if (retries === maxRetries) {
+        if (retries >= maxRetries) {
             throw err;
         }
         return await retryAndBackoff(fn, isRetryable, maxRetries, retries, base);

dist/index.js

@@ -363,7 +363,7 @@ async function retryAndBackoff(fn, isRetryable, maxRetries = 12, retries = 0, ba
         // It's retryable, so sleep and retry.
         await sleep(Math.random() * (Math.pow(2, retries) * base));
         retries += 1;
-        if (retries === maxRetries) {
+        if (retries >= maxRetries) {
             throw err;
         }
         return await retryAndBackoff(fn, isRetryable, maxRetries, retries, base);
@@ -451,7 +451,10 @@ async function run() {
         const unsetCurrentCredentials = unsetCurrentCredentialsInput.toLowerCase() === 'true';
         const disableRetryInput = core.getInput('disable-retry', { required: false }) || 'false';
         const disableRetry = disableRetryInput.toLowerCase() === 'true';
-        const maxRetries = parseInt(core.getInput('retry-max-attempts', { required: false })) || 12;
+        let maxRetries = parseInt(core.getInput('retry-max-attempts', { required: false })) || 12;
+        if (maxRetries < 1) {
+            maxRetries = 1;
+        }
         for (const managedSessionPolicy of managedSessionPoliciesInput) {
             managedSessionPolicies.push({ arn: managedSessionPolicy });
         }

src/helpers.ts

@@ -124,7 +124,7 @@ export async function retryAndBackoff<T>(
     // It's retryable, so sleep and retry.
     await sleep(Math.random() * (Math.pow(2, retries) * base));
     retries += 1;
-    if (retries === maxRetries) {
+    if (retries >= maxRetries) {
       throw err;
     }
     return await retryAndBackoff(fn, isRetryable, maxRetries, retries, base);

src/index.ts

@@ -44,7 +44,10 @@ export async function run() {
     const unsetCurrentCredentials = unsetCurrentCredentialsInput.toLowerCase() === 'true';
     const disableRetryInput = core.getInput('disable-retry', { required: false }) || 'false';
     const disableRetry = disableRetryInput.toLowerCase() === 'true';
-    const maxRetries = parseInt(core.getInput('retry-max-attempts', { required: false })) || 12;
+    let maxRetries = parseInt(core.getInput('retry-max-attempts', { required: false })) || 12;
+    if (maxRetries < 1) {
+      maxRetries = 1;
+    }
     for (const managedSessionPolicy of managedSessionPoliciesInput) {
       managedSessionPolicies.push({ arn: managedSessionPolicy });
     }

test/index.test.ts

@@ -632,6 +632,25 @@ describe('Configure AWS Credentials', () => {
     expect(core.setFailed).toHaveBeenCalledWith('Could not assume role with OIDC: ');
   });
 
+  test('max retries negative input does not retry', async () => {
+    process.env['GITHUB_ACTIONS'] = 'true';
+    process.env['ACTIONS_ID_TOKEN_REQUEST_TOKEN'] = 'test-token';
+    jest.spyOn(core, 'getInput').mockImplementation(
+      mockGetInput({
+        'role-to-assume': ROLE_ARN,
+        'aws-region': FAKE_REGION,
+        'retry-max-attempts': '-1',
+      })
+    );
+    mockedSTS.reset();
+    mockedSTS.on(AssumeRoleWithWebIdentityCommand).rejects();
+
+    await run();
+
+    expect(mockedSTS.commandCalls(AssumeRoleWithWebIdentityCommand).length).toEqual(1);
+    expect(core.setFailed).toHaveBeenCalledWith('Could not assume role with OIDC: ');
+  });
+
   test('role external ID provided', async () => {
     jest
       .spyOn(core, 'getInput')